Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/IB/MLX5: Fasten DC support check #3301

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

Artemy-Mellanox
Copy link
Contributor

No description provided.

srq_attr.attr.max_wr = 1;
srq = ibv_create_srq(pd, &srq_attr);
if (srq == NULL) {
ucs_error("ibv_create_cq() failed: %m");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ibv_create_srq ?

attr.path_mtu = IBV_MTU_256;
attr.ah_attr.port_num = 1;

ret = ibv_modify_qp(qp, &attr, IBV_QP_STATE |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe extract new function just for testing if DC works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would entire old function.

@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/6388/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/9120/ for details (Mellanox internal link).

goto err;
}

attr.qp_state = IBV_QPS_RTR;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

if (qp == NULL) {
goto err_qp;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not creating a qp enough to check DC support?
Why is it required to move it to RTR state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to RTR state triggers in kernel actual CREATE_DCT

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/6462/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/9199/ for details (Mellanox internal link).

@yosefe yosefe merged commit 1470a0d into openucx:v1.5.x Mar 8, 2019
@Artemy-Mellanox Artemy-Mellanox deleted the topic/dc_check branch July 22, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants